Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assetto Corsa artifacting and GPU hangs #648

Closed
Lahvuun opened this issue Sep 18, 2018 · 10 comments
Closed

Assetto Corsa artifacting and GPU hangs #648

Lahvuun opened this issue Sep 18, 2018 · 10 comments
Labels

Comments

@Lahvuun
Copy link

Lahvuun commented Sep 18, 2018

Disabling reflections in Assetto Corsa causes image artifacts and general GPU instability.

Software information

Assetto Corsa

System information

  • GPU: AMD Radeon RX 560
  • Driver: mesa-git-c9dbe52f848ae795ae9fdd7cbeca857db27dcc48
  • Wine version: wine-staging-3.16
  • DXVK version: dxvk-git-bf5476900ada0714a86737ddc96683721bffc605
  • LLVM: llvm-git-fbb826fa5c2e828f0e27944ae92c60fe68208609

Apitrace file(s)

https://drive.google.com/open?id=1yvh6uJg-p0IMrEo9bropR-KVCLIc_UEX

Log files

@doitsujin
Copy link
Owner

doitsujin commented Sep 18, 2018

In case of GPU hangs, please check #252.

When replaying the trace I pretty much instantly get a GPU hang, is that what happens in the game as well or is this an additional issue caused by apitrace? (this sometimes happens as well, just want to make sure)

@Lahvuun
Copy link
Author

Lahvuun commented Sep 18, 2018

The results vary for me: sometimes apitrace renders until the end (leaving every other window in X frozen), sometimes it hangs at the start. I am able to see artifacts (the first few frames after the loading screen) in the apitrace before the hang, however. The game is more stable, but eventually it hangs as well. During this one of my cores is at 100% constantly, no matter the scene.

This apitrace was made under wine, if that matters.

@doitsujin
Copy link
Owner

Do you have access to a Windows machine, and if so, can you record an apitrace there? Something's fishy there.

The GPU hang occurs because the game tries to create a texture with a size of 0x0, and DXVK doesn't return the appropriate error code. This is fixed with 837a3f5, and replaying the apitrace will now crash because the texture cannot be created.

@doitsujin
Copy link
Owner

Update: I got a Windows trace from someone else, and it appears that the game creates a 2048x2048 texture where it creates a 0x0 texture in your trace. No idea why though.

Does the game now work correctly with latest master or are there still issues?

@Lahvuun
Copy link
Author

Lahvuun commented Sep 18, 2018

Do you have access to a Windows machine, and if so, can you record an apitrace there?

I'm sorry, I don't have a Windows machine. I can set up dual-boot in a few hours, though.

Does the game now work correctly with latest master or are there still issues?

The game freezes on loading screen with current master (837a3f5).

I got a Windows trace from someone else, and it appears that the game creates a 2048x2048 texture where it creates a 0x0 texture in your trace

Are reflections disabled in that apitrace?
If I set the "reflection quality" to anything other than "none" the game runs completely fine for me.

@doitsujin doitsujin added bug and removed amd radv labels Sep 18, 2018
doitsujin added a commit that referenced this issue Sep 19, 2018
Assetto Corsa tries to do some questionable things when reflections
are disabled in the game options. Refs #648.
@doitsujin
Copy link
Owner

Are reflections disabled in that apitrace?

I asked and got another one with reflections disabled this time. The game does indeed try to create a 0x0 texture and keeps using it, which results in errors and silently dropped calls with native D3D11 but caused DXVK to crash.

Should be fixed in a95f292, please test if it works now.

@Lahvuun
Copy link
Author

Lahvuun commented Sep 19, 2018

a95f292 fails to build for me: https://pastebin.com/RYVG8Jgp

Am I doing something wrong?

doitsujin added a commit that referenced this issue Sep 19, 2018
Assetto Corsa tries to do some questionable things when reflections
are disabled in the game options. Refs #648.
@doitsujin
Copy link
Owner

Sorry, my fault. Should be fixed now.

@Lahvuun
Copy link
Author

Lahvuun commented Sep 19, 2018

35238ec completely resolves the issue for me: no artifacting, no previous GPU issues.

@doitsujin
Copy link
Owner

Thanks for the quick feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants