Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[d3d9] Only force AF on textures with mipmaps. #1673

Closed
wants to merge 1 commit into from

Conversation

CME42
Copy link
Contributor

@CME42 CME42 commented Jun 21, 2020

This fixes some visual artifacts (#1666) on nvidia with UE3 when
anisotropic filtering is enabled through d3d9.samplerAnisotropy.

@aufkrawall
Copy link

I can confirm it fixes the issue. Thanks for that pleasant surprise! :)

@aufkrawall
Copy link

Unfortunately, this greatly degrades AF quality in Oblivion:
22330_20200621212352_1
22330_20200621212455_1

@CME42
Copy link
Contributor Author

CME42 commented Jun 21, 2020

Thanks for testing, I'll close this PR for now, can you please upload an apitrace of the spot in the screenshot?

@CME42 CME42 closed this Jun 21, 2020
@aufkrawall
Copy link

This fixes some visual artifacts on nvidia with UE3 when
anisotropic filtering is enabled through d3d9.samplerAnisotropy.
@CME42
Copy link
Contributor Author

CME42 commented Jun 23, 2020

Thanks, I've force-pushed a change in the aniso branch, but I'm not sure what the performance implications are and what else i may have missed, perhaps there is a better way to do this.

@aufkrawall
Copy link

Indeed Oblivion looks normal now (afaict from a quick glimpse) and Lili is still fixed. I'll test and benchmark some more and keep you updated.

@aufkrawall
Copy link

aufkrawall commented Jun 24, 2020

I've additionally tested the following games:
Borderlands 2 (btw. showed the same issue as Lili without the PR)
Tropico 4
Serious Sam 2
Mirror's Edge
Left 4 Dead 2

AF (whether forced via DXVK or not) works fine in all of these games with the updated PR applied, both quality and performance wise.

@aufkrawall
Copy link

aufkrawall commented Jun 25, 2020

@CME42 Perhaps the same should be done for D3D11? The Forest (Unity Engine) seems to show this issue too.
Edit: doitsujin mentioned elsewhere that this can't be done in the same way for D3D11.

@aufkrawall
Copy link

This PR doesn't seem to cause any harm with forced AF on Polaris with radv/amdvlk.

@ViNi-Arco
Copy link

Hi CME42..
Applying your PR introduces shimmering on GTAIII and GTAVC textures

see below👇

Click here

With this PR:
https://img.tpx.cz/uploads/IIITextureBrokenFilter.png
With DXVK Stock:
https://img.tpx.cz/uploads/IIITextureWorkFilter.png

With this PR:
https://img.tpx.cz/uploads/TextureBrokenFilterVC.png
With DXVK Stock:
https://img.tpx.cz/uploads/TextureWorkFilterVC.png

@Joshua-Ashton
Copy link
Collaborator

I'm really not a fan of adding resource tracking for an app profile, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants