Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added script to setup dlls in wine #19

Merged
merged 3 commits into from
Jan 21, 2018
Merged

Conversation

Raffarti
Copy link
Contributor

Out for review.

@Raffarti
Copy link
Contributor Author

Raffarti commented Jan 20, 2018

This does not create the dlls links. I'm not sure whether it has to be implemented in meson.

@doitsujin
Copy link
Owner

Just to make sure I understand correctly, this way of setting up the DLLs would work best if the DLLs were named d3d11_vk.dll and dxgi_vk.dll, right? In that case I'd just change the library names so that we don't need any symlinks at all. It kind of breaks the current way of using the libraries, but with the setup script making things easier anyway I believe it's worth it.

In any case I'd like one minor change, and that is to move wine_utils out of the src directory into the top level directory. src should only contain code that is required to build the libraries.

@Raffarti
Copy link
Contributor Author

renaming the dlls would also do

@doitsujin
Copy link
Owner

Alright, will tend to that later, thanks.

@doitsujin doitsujin merged commit 16eef61 into doitsujin:master Jan 21, 2018
@Raffarti Raffarti deleted the wine_script branch January 21, 2018 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants