-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[d3d9+dxso] Rely on robustness for unset SWVP constants #2282
[d3d9+dxso] Rely on robustness for unset SWVP constants #2282
Conversation
ee7a374
to
b89b8d8
Compare
7c49968
to
2c5d5cd
Compare
TODO:
EDIT: |
3c8d284
to
44f6211
Compare
1738088
to
8fe9415
Compare
Pls do not forget about Lines 442 to 451 in 67391a7
|
Nice catch, will remove that soon. |
7cfca50
to
c18ac33
Compare
Thanks for the review @DadSchoorse. Implemented all your feedback. |
c18ac33
to
63df91f
Compare
I decided to remove the SSBO fallback when robustness2 is not supported. Instead we just copy everything like we did before. Same thing also happens when any of the constant buffers does not match the robustness2 alignment. Luckily, it all works out in practice with the 256 byte alignment on Nvidia hardware. |
94141e8
to
97dd2c8
Compare
97dd2c8
to
f3c4dc6
Compare
This implements Joshuas idea to rely on robustness2 for constants that the application hasn't set yet.
SWVP:
HWVP/PS:
When robustness2 is not supported or the alignment does not work out (It does work on Nvidia), we just copy everything like we did before.
Fixes #2264