Simple implementation of SmartVector. #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
it is late evening and I have just implemented simple Smartvector.
It uses linked list under the hood. Implementation passes tests we developed on last Wednesday, but it fails a new test I added today. It turns out that storing indexes into bitmap is somehow flawed. It can return wrong value for requested index depending on how we grow linked list, this is demonstrated in fourth test case called
TestStoreBothDifferentAndEqualAdjacentValues
.This test case adds 4 values to SmartVector:
which result in linked list with following structure
[101:10]->[001:11]->[010:12]
then we query for value at index 1 (binary
001
) we get value 10 from the vector which is wrong as we should get value 11.As I said results depend on how we grow underlying linked list.