Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving the basic web server #38

Closed
mwistrand opened this issue Jan 15, 2018 · 1 comment
Closed

Improving the basic web server #38

mwistrand opened this issue Jan 15, 2018 · 1 comment
Labels
discussion enhancement
Milestone
rc.1

Comments

@mwistrand
Copy link
Contributor

Currently, running dojo build -s just starts a web server that blindly serves the output directory for the current mode (e.g., /output/dev). However, this does not work for --mode=test as there are only two files there (functional.js and unit.js), and does not allow anything but the hash router to be used in other modes.

For dev and dist modes, one solution is to serve all extension-less routes from / and continue delivering assets (JS, CSS, HTML, images) statically. For test mode, we could attempt to serve node_modules/intern/index.html, but I am inclined to think that running tests is the purview of @dojo/cli-test-intern and that --serve should be disabled in test mode.
This was referenced Jan 17, 2018
Closed
Merged
@mwistrand
Copy link
Contributor Author

Resolved by #41.

@dylans dylans added this to the rc.1 milestone Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion enhancement
Projects
None yet
Milestone
rc.1
Development

No branches or pull requests
2 participants
@dylans @mwistrand