Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using --serve in test mode does not serve the test runner #40

Closed
agubler opened this issue Jan 17, 2018 · 2 comments
Closed

Using --serve in test mode does not serve the test runner #40

agubler opened this issue Jan 17, 2018 · 2 comments
Milestone

Comments

@agubler
Copy link
Member

agubler commented Jan 17, 2018

Enhancement

At the moment using the --serve option when building in test mode is pretty useless as it serves the output/test directory meaning that it does not enable running the tests in the browser.

We should consider serving from the project root or disabling --serve when building the tests.

@mwistrand
Copy link
Contributor

This is very similar to #38, which also throws in improved handling for the other modes.

@agubler
Copy link
Member Author

agubler commented Jan 17, 2018

@mwistrand excellent, I was transferring the issue from a comment on cli-build-webpack dojo/cli-build-webpack#259 (comment).

If it is a duplicate of #38 feel free to close.

@dylans dylans added this to the 2018.03 milestone Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants