Support the dev-server for IE11 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwistrand
reviewed
Aug 14, 2018
package.json
Outdated
| "cli-columns": "3.1.2", | ||
| "copy-webpack-plugin": "4.5.2", | ||
| "css-loader": "0.28.7", | ||
| "eventsource-polyfill": "^0.9.6", |
There was a problem hiding this comment.
Any reason not to pin this dependency as we've done with the others?
There was a problem hiding this comment.
Ah thanks - just npm installed didn't I!
mwistrand
approved these changes
Aug 14, 2018
|
Guess I need to update some tests! Thanks CI. |
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 59.71% 59.81% +0.09%
==========================================
Files 8 8
Lines 427 428 +1
Branches 92 92
==========================================
+ Hits 255 256 +1
Misses 172 172
Continue to review full report at Codecov.
|
mwistrand
approved these changes
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug
Adds an explicit dependency on
strip-ansi@3.0.1, as from version4.0.0the package is using ES2015 javascript and cannot be executed by IE11.Also adds the
eventsource-polyfillfor the webpack dev server, as it is required for using IE11.