Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding eject command, issue #4 #13

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Adding eject command, issue #4 #13

merged 1 commit into from
Mar 8, 2017

Conversation

rorticus
Copy link
Contributor

Type: bug / feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Adding support for cli's eject command. When ejecting the tests, you get:

  • Intern config files for local, browser stack, saucelabs, and testingbot.
  • devDependencies for intern, istanbul, remap-instanbul, mockery, and sinon.

Note: Tested on kitchen-sink and successfully manually ran the tests after ejecting the command.

Resolves #4

@codecov-io
Copy link

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #13   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          65     66    +1     
  Branches       13     13           
=====================================
+ Hits           65     66    +1
Impacted Files Coverage Δ
src/main.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdbb008...0465447. Read the comment docs.

@dylans dylans modified the milestones: 2017.02, 2017.03 Feb 28, 2017
@tomdye tomdye merged commit 1f87267 into dojo:master Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants