Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README [ciskip] #97

Merged
merged 2 commits into from Feb 9, 2018
Merged

Updated README [ciskip] #97

merged 2 commits into from Feb 9, 2018

Conversation

devpaul
Copy link
Member

@devpaul devpaul commented Feb 9, 2018

Adds updated usage and information for running tests on testing platforms

Resolves #96

README.md Outdated

Runs tests built using `@dojo/cli-build-webpack`, or `@dojo/cli-build-app`.
This project is a plugin for the Dojo CLI. Please visit the [Dojo CLI] project for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a link in here? And swap plugin for command

[Dojo CLI](https://github/dojo/cli)

README.md Outdated

## How do I use this package?
The use `@dojo/cli-test-intern` in a project, install the packages:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"install the packages:" -> "install the package:"

README.md Outdated
dojo test -f
```

cli-test-intern will execute tests located at `./output/test/functional.js` in Chrome using Selenium and provide a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cli-test-intern -> @dojo/cli-test-intern

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And else where in the readme also

README.md Outdated
dojo test -u
```

cli-test-intern will execute tests located at `output/tests/unit.js` in node and in Chrome and provide a report
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cli-test-intern -> @dojo/cli-test-intern


### Testing services

Intern comes with support for running tests remotely on [BrowserStack], [SauceLabs], and [TestingBot]. You may use one
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning on adding links to BrowserStack, SauceLabs and TestingBot?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore me they do link, didn't know that :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're linked at the bottom.


[@dojo/cli-build-app]: https://github.com/dojo/cli-build-app
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know you could do this :)

@devpaul devpaul merged commit 05fbf10 into dojo:master Feb 9, 2018
@dylans dylans added this to the rc.1 milestone Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants