Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli should not error if no commands have implemented eject #95

Closed
agubler opened this issue Feb 1, 2017 · 0 comments
Closed

cli should not error if no commands have implemented eject #95

agubler opened this issue Feb 1, 2017 · 0 comments
Assignees
@jdonaghue
Labels
bug
Milestone
2017.02

Comments

@agubler
Copy link
Member

agubler commented Feb 1, 2017

Currently eject throws an error if no commands have implemented it, we should either not throw an error and report that now commands have implemented or not register the command if there are no available commands to eject,
@agubler agubler added the bug label Feb 1, 2017
@agubler agubler added this to the 2017.02 milestone Feb 1, 2017
jdonaghue added a commit to jdonaghue/cli that referenced this issue Feb 4, 2017
@jdonaghue
refs dojo#95 Don't throw error when nothing to do, and add nothing to…
90848fd 
… do message when no commands have eject method
@jdonaghue jdonaghue mentioned this issue Feb 4, 2017
Merged
agubler pushed a commit that referenced this issue Feb 13, 2017
@jdonaghue @agubler
Don't error when nothing to do (#99)
00de5d2 
* refs #95 Don't throw error when nothing to do, and add nothing to do message when no commands have eject method

* Change message when nothing to do
@dylans dylans closed this as completed Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdonaghue jdonaghue

Labels
bug
Projects
None yet
Milestone
2017.02
Development

No branches or pull requests
3 participants
@jdonaghue @dylans @agubler