Make validate asynchronous #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rorticus
approved these changes
Nov 9, 2018
|
Please don't merge this until we have created the v4 branch. |
JamesLMilner
commented
Nov 12, 2018
| @@ -42,7 +42,7 @@ export type ValidationWrapper = { | |||
| }; | |||
|
|
|||
| export interface ValidateHelper { | |||
| validate(validateOpts: ValidationWrapper): Promise<any>; | |||
| validate(validateOpts: ValidationWrapper): Promise<boolean>; | |||
There was a problem hiding this comment.
@agubler @matt-gadd does this look like the interface we want? I was thinking about Promise<any> but I can't think if we'd want to return anything other than true or false back from a validate call. What do you think?
There was a problem hiding this comment.
Seems like a boolean result for validate fits
agubler
reviewed
Nov 14, 2018
src/commands/validate.ts
Outdated
| } catch (error) { | ||
| logValidateFunctionFailed(error); | ||
| noMismatches = false; | ||
| return Promise.all( |
There was a problem hiding this comment.
I find this really hard to follow, do you think we could make it clearer? Also I don't think you want to await in the map, as you just want to await the resulting array, right?
JamesLMilner
force-pushed
the
async-validate
branch
from
5e2d24a
to
3f5c220
Compare
agubler
approved these changes
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
At the moment validate expects a boolean return type but the ValidateHelper returns a Promise, meaning you can't use the helper in a command.
Resolves #272