Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

has.ts causes loading the main bundle to crash in Internet Explorer 11 in https #387

Closed
szwoelf opened this issue Apr 4, 2018 · 4 comments
Milestone

Comments

@szwoelf
Copy link

szwoelf commented Apr 4, 2018

Bug

When using a bundled application with Internet Explorer 11 together with https the bundle is not loaded. IE raises an "access denied" error in the main bundle.

Package Version: dojo RC1 (and RC2)

Code

can be tested with:

  • create a fresh app with dojo/cli
  • add the following code after the imports:

import request from '@dojo/core/request'; console.log(request);

  • pack the application with dojo build -m dist
  • access the application via https://localhost:... in IE 11

Actual behavior:

IE 11 will not show the rotating elements - it will show an error in the console (no SVG, ... )

@szwoelf
Copy link
Author

szwoelf commented Apr 4, 2018

Internet Explorer seems to have a problem with the request to http://www.google.com .... (see line 22 in has.ts) ....

@dasa
Copy link

dasa commented Apr 4, 2018

Maybe it should be using https, like it does here in Dojo 1: https://github.com/dojo/dojo/blob/master/request/xhr.js#L40

@szwoelf
Copy link
Author

szwoelf commented Apr 5, 2018

Hi ... yes. I patched this in the has.js in the node_modules, performed a build and re-tested this in IE. Using the URL https://www.google.com works. Possibly the comment of the code mentioned by @dasa should also be added ...

@agubler
Copy link
Member

agubler commented Apr 5, 2018

@szwoelf do you fancy raising a pull request to fix this?

jason0x43 added a commit to jason0x43/core that referenced this issue Apr 5, 2018
For the blob test, make the test request using the active protocol
rather than always using http. At least IE11 will throw an exception
when making an http request from an https domain.

references dojo#387
jason0x43 added a commit to jason0x43/core that referenced this issue Apr 5, 2018
For the blob test, make the test request using the active protocol
rather than always using http. At least IE11 will throw an exception
when making an http request from an https domain.

references dojo#387
@dylans dylans added this to the 2.0.0 milestone Apr 19, 2018
rorticus pushed a commit that referenced this issue Apr 19, 2018
For the blob test, make the test request using the active protocol
rather than always using http. At least IE11 will throw an exception
when making an http request from an https domain.

references #387
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants