Remove destructuring from generateRequestUrl signature

[nicknisi]

Description:

The generateRequestUrl function is correct, but its usage of destructuring with a default argument is throwing an error in the way that ts-loader reads the code. Issue TypeStrong/ts-loader#442 describes the issue, but it hasn't really had much progress, and it's easier to just change this.

[kitsonk]

Also the CI is failing due to some sort of TypeScript error. Not entirely sure why but we should find out what is going on.

[kitsonk]

Why not just move the destructering down?

export function generateRequestUrl(url: string, options: RequestOptions = {}): string {
    let { query, cacheBust } = options;

[nicknisi]

I changed it for a couple reasons:

• I thought it'd be weird to set query and then set it again on the line after it.

	let { query, cacheBust } = options;
	query = new UrlSearchParams(query).toString();

• I didn't want cacheBust to be a let variable since it's not modified.

[kitsonk]

Yeah, ok, and it is only accessed once (cacheBust) 👍

[nicknisi]

It looks like the errors are related to errors in functional tests, and not to changes in this PR.

Running "ts:dev" (ts) task
Compiling...
Using tsc v2.4.2
tests/functional/text/textPlugin.ts(25,30): error TS2339: Property 'text' does not exist on type '{}'.
tests/functional/text/textPlugin.ts(30,30): error TS2339: Property 'text' does not exist on type '{}'.
tests/functional/text/textPlugin.ts(35,30): error TS2339: Property 'text' does not exist on type '{}'.
tests/functional/text/textPlugin.ts(40,30): error TS2339: Property 'text' does not exist on type '{}'.

I'm happy to address, but I can't reproduce locally.

[kitsonk]

Found the issue and fixed it in #364. I am not sure why it wasn't reproducible on your machine though.