refs #15878. Let applications set win.doc.dojoClick to false, and gen…

…erate synthetic clicks like in 1.8 in that case. !strict

git-svn-id: http://svn.dojotoolkit.org/src/dojox/trunk@31244 560b804f-0ae3-0310-86f3-f6aa0a117693

mobile/Switch.js

@@ -13,8 +13,9 @@ define([
 	"dijit/_WidgetBase",
 	"./sniff", 
 	"./_maskUtils",
+	"./common",
 	"dojo/has!dojo-bidi?dojox/mobile/bidi/Switch"
-], function(array, connect, declare, event, win, domClass, domConstruct, domStyle, domAttr, touch, Contained, WidgetBase, has, maskUtils, BidiSwitch){
+], function(array, connect, declare, event, win, domClass, domConstruct, domStyle, domAttr, touch, Contained, WidgetBase, has, maskUtils, dm, BidiSwitch){
 
 	// module:
 	//		dojox/mobile/Switch
@@ -236,6 +237,10 @@ define([
 			array.forEach(this._conn, connect.disconnect);
 			this._conn = null;
 			if(this.innerStartX == this.inner.offsetLeft){
+				// need to send a synthetic click?
+				if(has("touch") && has("clicks-prevented")){
+					dm._sendClick(this.inner, e);
+				}
 				return;
 			}
 			var newState = (this.inner.offsetLeft < -(this._width/2)) ? "off" : "on";

mobile/common.js

@@ -22,6 +22,27 @@ define([
 	// tell dojo/touch to generate synthetic clicks immediately
 	// and regardless of preventDefault() calls on touch events
 	win.doc.dojoClick = true;
+	/// ... but let user disable this by removing dojoClick from the document
+	if(has("touch")){
+		// Do we need to send synthetic clicks when preventDefault() is called on touch events?
+		// This is normally true on anything except Android 4.1+ and IE10, but users reported
+		// exceptions like Galaxy Note 2. So let's use a has("clicks-prevented") flag, and let
+		// applications override it through data-dojo-config="has:{'clicks-prevented':true}" if needed.
+		has.add("clicks-prevented", !(has("android") >= 4.1 || has("ie") >= 10));
+		if(has("clicks-prevented")){
+			dm._sendClick = function(target, e){
+				// dojo/touch will send a click if dojoClick is set, so don't do it again.
+				for(var node = target; node; node = node.parentNode){
+					if(node.dojoClick){
+						return;
+					}
+				}
+				var ev = win.doc.createEvent("MouseEvents"); 
+				ev.initMouseEvent("click", true, true, win.global, 1, e.screenX, e.screenY, e.clientX, e.clientY); 
+				target.dispatchEvent(ev);
+			};
+		}
+	}
 
 	dm.getScreenSize = function(){
 		// summary:

mobile/scrollable.js

@@ -547,6 +547,16 @@ define([
 				if(clicked){ // clicked, not dragged or flicked
 					this.hideScrollBar();
 					this.removeCover();
+					// need to send a synthetic click?
+					if(has("touch") && has("clicks-prevented") && !this.isFormElement(e.target)){
+						var elem = e.target;
+						if(elem.nodeType != 1){
+							elem = elem.parentNode;
+						}
+						setTimeout(function(){
+							dm._sendClick(elem, e);
+						});
+					}
 					return;
 				}
 				speed = this._speed = this.getSpeed();

mobile/tests/test_html-form-controls.html

@@ -11,11 +11,15 @@
 
 	<script type="text/javascript">
 		require([
+			"dojo/_base/window",
 			"dojox/mobile/parser",
 			"dojox/mobile",
 			"dojox/mobile/compat",
 			"dojox/mobile/ScrollableView"
-		]);
+		], function(win){
+			// disable synthetic clicks from dojo/touch
+			win.doc.dojoClick = false; 
+		});
 	</script>
 
 	<style>