Fix dom rendering of attributes with empty data #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dylans
approved these changes
Aug 9, 2018
dylans
pushed a commit
that referenced
this pull request
Aug 9, 2018
(cherry picked from commit 294ed02)
dylans
pushed a commit
that referenced
this pull request
Aug 9, 2018
(cherry picked from commit 294ed02)
dylans
pushed a commit
that referenced
this pull request
Aug 9, 2018
(cherry picked from commit 294ed02)
dylans
pushed a commit
that referenced
this pull request
Aug 9, 2018
(cherry picked from commit 294ed02)
dylans
pushed a commit
that referenced
this pull request
Aug 9, 2018
(cherry picked from commit 294ed02)
dylans
pushed a commit
that referenced
this pull request
Aug 9, 2018
(cherry picked from commit 294ed02)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #288.
The attribute value wasn't updated when the DTL expression inside of it resulted in an empty string. The side effect was that the attribute's value remained with the DTL expression inside of it (see #288 for more details).
Added a test case that has a much smaller code footprint than the example in the issue linked above.