Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move JSX types to local namespace #46

Closed
agubler opened this issue Jul 30, 2018 · 0 comments · Fixed by #818
Closed

Move JSX types to local namespace #46

agubler opened this issue Jul 30, 2018 · 0 comments · Fixed by #818
Labels
enhancement New feature or request

Comments

@agubler
Copy link
Member

agubler commented Jul 30, 2018

@jcfranco commented on Wed Apr 18 2018

Enhancement

It'd be nice to move the global JSX typings to a local namespace since TypeScript 2.8 now resolves JSX via the factory function. This is also recommended in their release notes:

Going forward, we recommend that new JSX-oriented libraries avoid placing JSX in the global scope, and instead export it from the same location as the respective factory function.

@matt-gadd commented on Mon Jun 11 2018

We plan to update this when we move to TypeScript 2.9
@agubler agubler added the enhancement New feature or request label Jul 30, 2018
@agubler agubler mentioned this issue Jul 17, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move JSX types to tsx namespace agubler/framework
1 participant
@agubler