Update testing reference guide #435
Conversation
| @@ -243,56 +389,6 @@ v('div', { | |||
| ]) | |||
| ``` | |||
|
|
|||
| ### `harness.expectPartial` | |||
There was a problem hiding this comment.
Removed this because we don't really want to promote its use. With assertion templates it has become less useful as the templates can be easily manipulated but still test the whole widget.
docs/en/testing/supplemental.md
Outdated
|
|
||
| ##### Mock `node` Middleware | ||
|
|
||
| Using `createMockNodeMiddleware` from `@dojo/framework/testing/mocks/middleware/node` creates a mock node middleware. To set the expected return from the node mock, call the `mockNode` with a `key` and expected node. |
There was a problem hiding this comment.
Given that node could mean a DOM Node or Node.js, I think the first instance of this should be more specific, e.g. creates a mock middleware for a DOM node.
There was a problem hiding this comment.
urgh the middleware is called node though.
There was a problem hiding this comment.
Yeah it's not a mock middleware for a "DOM nodeit's a mock middleware for thenode` middleware. So think I'm going to leave it as it is.
There was a problem hiding this comment.
I would suggest "creates a mock for the node middleware" for ease of reading comprehension.
docs/en/testing/supplemental.md
Outdated
| }); | ||
| h.expect(/* assertion template for `Loading`*/); | ||
|
|
||
| // would be useful to assert the calls to processes effectively stubbed |
There was a problem hiding this comment.
This comment seems a bit weird to be in the docs as it feels more like an internal todo
docs/en/testing/basic-usage.md
Outdated
| ```bash | ||
| TESTINGBOT_SECRET=<secret> TESTINGBOT_KEY=<key> dojo test -a -c saucelabs | ||
| ``` | ||
| Using the `setChildren` method of an Assertion Template with the `~key` value you assigned will return a assertion template with the updated virtual DOM structure that you can test your widget output against. | ||
|
|
||
| [browserstack]: https://www.browserstack.com/ |
There was a problem hiding this comment.
You can remove this browserstack ref since it's not referenced in this doc anymore.
Co-Authored-By: Dylan Schiemann <dylan@dojotoolkit.org>
agubler
force-pushed
the
testing-ref-guide-update
branch
from
afbaf3a
to
f107fb3
Compare
agubler
changed the title
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Update the testing reference guide with new APIs and features for supporting mock middleware.