Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for forward compatibility with Typescript 4+ #892

Merged
merged 1 commit into from
May 13, 2021

Conversation

agubler
Copy link
Member

@agubler agubler commented Mar 23, 2021

Type: feature

The following has been addressed in the PR:

Description:

Small changes to support up to TS 4.1.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 23, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a1cd19f:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #892 (a1cd19f) into master (ccaedb3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #892      +/-   ##
==========================================
+ Coverage   94.59%   94.60%   +0.01%     
==========================================
  Files         127      127              
  Lines        8137     8139       +2     
  Branches     1901     1901              
==========================================
+ Hits         7697     7700       +3     
+ Misses        440      439       -1     
Impacted Files Coverage Δ
src/core/mixins/Focus.ts 100.00% <100.00%> (ø)
src/core/mixins/I18n.ts 91.52% <100.00%> (ø)
src/core/mixins/Themed.ts 99.00% <100.00%> (ø)
src/routing/Router.ts 100.00% <100.00%> (+0.45%) ⬆️
src/shim/array.ts 100.00% <100.00%> (ø)
src/testing/renderer.ts 97.37% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccaedb3...a1cd19f. Read the comment docs.

@agubler agubler merged commit 29854e3 into dojo:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants