Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache the function wrapper, no need to recreate each render. #903

Merged
merged 1 commit into from May 19, 2021

Conversation

agubler
Copy link
Member

@agubler agubler commented May 19, 2021

Type: bug/feature

The following has been addressed in the PR:

Description:

There is no need to recreate the property function wrapper each render, in addition this is causing issues with the custom element wrapper because the functions will always be referentially different.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 51aa1c2:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #903 (51aa1c2) into master (29854e3) will increase coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #903   +/-   ##
=======================================
  Coverage   94.60%   94.61%           
=======================================
  Files         127      127           
  Lines        8141     8145    +4     
  Branches     1900     1901    +1     
=======================================
+ Hits         7702     7706    +4     
  Misses        439      439           
Impacted Files Coverage Δ
src/core/vdom.ts 97.79% <88.88%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29854e3...51aa1c2. Read the comment docs.

@agubler agubler merged commit 3cf7f1b into dojo:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants