Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ESLint configuration #35

Merged
merged 1 commit into from
Aug 18, 2020
Merged

feat: add ESLint configuration #35

merged 1 commit into from
Aug 18, 2020

Conversation

bitpshr
Copy link
Member

@bitpshr bitpshr commented Aug 13, 2020

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

This pull request adds a new ESLint base configuration file.

Resolves #31
Replaces #32

@bitpshr bitpshr mentioned this pull request Aug 13, 2020
3 tasks
@bitpshr bitpshr changed the title Feat/eslint feat: add ESLint configuration Aug 13, 2020
@bitpshr bitpshr requested a review from msssk August 13, 2020 15:59
@bitpshr
Copy link
Member Author

bitpshr commented Aug 18, 2020

This is a low-risk PR since it's only adding a configuration file. For the sake of keeping forward progress on this, I'm going to land this work so we can get a release out the door. Always happy to address any comments retroactively.

@bitpshr bitpshr merged commit d75338e into dojo:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add base eslint configuration
1 participant