Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

dojo/compose version update and get rid of extend #63

Merged
merged 2 commits into from Dec 6, 2016
Merged

dojo/compose version update and get rid of extend #63

merged 2 commits into from Dec 6, 2016

Conversation

lzhoucs
Copy link
Contributor

@lzhoucs lzhoucs commented Dec 2, 2016

Type: feature

Description:

  • Update compose version
  • Get rid of deprecated extend

Related Issue: #62

Please review this checklist before submitting your PR:

  • There is a related issue
  • All contributors have signed a CLA
  • All code matches the style guide
  • The code passes the CI tests
  • Unit or Functional tests are included in the PR
  • The PR increases or maintains the overall unit test coverage percentage
  • The code is ready to be merged

@agubler
Copy link
Member

agubler commented Dec 2, 2016

urgh I approved but CI failed....

@lzhoucs
Copy link
Contributor Author

lzhoucs commented Dec 2, 2016

The CI has been hanging on iphone 9.3 which is not caused by changes in this PR:

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

@dylans dylans added this to the 2016.12 milestone Dec 5, 2016
@maier49 maier49 merged commit 42a1c5c into dojo:master Dec 6, 2016
@lzhoucs lzhoucs deleted the compose-version-update branch December 9, 2016 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants