You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The listboxes presented by timepicker / combo box etc do not have a max height and as such they can run right off of a screen. This makes it very hard for a user to get to the value they require.
They also do not have a scrollbar and as such you cannot scroll through results without losing your place on the page.
I set a max-height to test keyboard scrolling behavior in development, so the requisite styles and behavior are there. All it would need is a max-height style. I'm leery of putting this directly in our theme CSS though, since the best max-height can be very context-dependent.
Would you be OK with adding this to our examples, or do you want it directly in the theme? Alternatively, do you think we need to add logic to the widget itself to prevent it going off-screen?
@tomdye commented on Fri Feb 02 2018
Bug
The listboxes presented by timepicker / combo box etc do not have a max height and as such they can run right off of a screen. This makes it very hard for a user to get to the value they require.
They also do not have a scrollbar and as such you cannot scroll through results without losing your place on the page.
@smhigley commented on Fri Feb 02 2018
I set a
max-height
to test keyboard scrolling behavior in development, so the requisite styles and behavior are there. All it would need is amax-height
style. I'm leery of putting this directly in our theme CSS though, since the best max-height can be very context-dependent.Would you be OK with adding this to our examples, or do you want it directly in the theme? Alternatively, do you think we need to add logic to the widget itself to prevent it going off-screen?
@tomdye commented on Fri Feb 02 2018
I think that it needs to
just work
as expected out of the box. Perhaps a max height property as you suggested defaulting to a sensible value.The text was updated successfully, but these errors were encountered: