Fixing _WidgetBase #115
Closed
Fixing _WidgetBase #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 14, 2017 11:14
…Mixin and _FocusMixin were incorrectly named as _WidgetBase
|
|
| interface _FocusMixin { } | ||
|
|
||
| interface _WidgetBase extends dojo.Stateful, Destroyable { | ||
| interface _FocusMixin extends _WidgetBase { |
There was a problem hiding this comment.
According to https://github.com/dojo/dijit/blob/master/_FocusMixin.js#L57, _FocusMixin does not inherit from _WidgetBase. When the file is required, it augments _WidgetBase with a bunch of other properties. If I tried to extend from_FocusMixin and expected all the properties from _WidgetBase to be there it would not work as I expect it to.
I'm not really sure how to express this stuff properly from the definition file.
| interface _FocusMixin { } | ||
|
|
||
| interface _WidgetBase extends dojo.Stateful, Destroyable { | ||
| interface _FocusMixin extends _WidgetBase { |
There was a problem hiding this comment.
I think we should add the focused property to the definition https://github.com/dojo/dijit/blob/master/_FocusMixin.js#L17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After noticing there were 4
_WidgetBaseinterfaces I did some digging and found two of them were actually misnamed definitions for_FocusMixinand_BidiMixin. I merged the other two into a single_WidgetBaseinterface.