Update basicApp example to use declare decorator and i18n #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 17, 2017 11:48
Add to the basicApp example a `declare` decorator that generates a `dojo/_base/declare` constructor from a class, update the `Dialog` widget to a class that uses that decorator, and add i18n messages.
dylans
approved these changes
Mar 19, 2017
dylans
approved these changes
Mar 21, 2017
|
Thank you for this! Could this example be extended to include translations (similar to the reference guide)? I can open a separate issue if needed. |
|
@jcfranco, yes, please open a separate issue as we'll forget about your suggestion since this PR is closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the "basicApp" example, add a
declaredecorator that generates adojo/_base/declareconstructor from a class, update theDialogwidget to a class that uses that decorator, and add i18n messages.