Fixes the EventedConstructor to use the same return type #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msssk
approved these changes
Sep 29, 2020
edhager
pushed a commit
to edhager/typings
that referenced
this pull request
May 12, 2021
* Fixes the EventedConstructor to use the same return type as DeclareConstructor<Evented> dojo#170 * Added explanatory comment as asked for in Review
edhager
added a commit
that referenced
this pull request
May 12, 2021
* Added module dojoy/rpc/Service * Missed a duplicate due to some merge on our side. * Fixes the EventedConstructor to use the same return type (#175) * Fixes the EventedConstructor to use the same return type as DeclareConstructor<Evented> #170 * Added explanatory comment as asked for in Review * Update typings for dojox/rpc/Service Co-authored-by: Heiko Studt <heiko.studt@goldpool.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the EventedConstructor to use the same return type as DeclareConstructor
#170
(PS: I made a hickup with the author email in the previous PR)