html runner now supports specifing .html tests in url #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable to me. |
jacobroufa
suggested changes
Oct 27, 2016
| domReady(function(){ | ||
| doh._fixHeight(); | ||
| doh.breakOnError= breakOnError; | ||
| for (var amdTests = [], i = 0, l = test.length; i < l; i++) { |
There was a problem hiding this comment.
amdTests should be declared at the top of the function scope, as it is used later, outside of this block.
| doh._fixHeight(); | ||
| doh.breakOnError= breakOnError; | ||
| for (var amdTests = [], i = 0, l = test.length; i < l; i++) { | ||
| var module = test[i]; |
There was a problem hiding this comment.
module should be declared at the top of the function scope, so it is not redeclared every time inside of this loop.
|
I have fixed the variable declaration. (no idea why my commit was marked with CLA: Error (Autor has not signed CLA), because it was commited with same account as the first one and I have signed CLA years ago) |
|
Hi @adros, since becoming the JS Foundation I think everyone needs to resign the CLA. |
adros
force-pushed
the
doh-runner-html
branch
from
39e0300
to
0b13b1f
Compare
dylans
approved these changes
Oct 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies doh html runner, so it supports opening tests written as .html, e.g.:
util/doh/runner.html?test=dijit/tests/Menu.html,dojox/lang/tests/array,dijit/tests/Destroyable.html