Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Google Closure Compiler to v20220601 #90

Merged
merged 2 commits into from
Jun 11, 2022

Conversation

dasa
Copy link
Contributor

@dasa dasa commented May 3, 2022

This update will allow the optimizeOptions.languageIn option to be set to ECMASCRIPT_2020 or ECMASCRIPT_2021. It's currently limited to ECMASCRIPT_2019.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 3, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dasa / name: Dasa Paddock (bec2c7e)

@dasa
Copy link
Contributor Author

dasa commented Jun 7, 2022

@dylans would this be considered for 1.17? v20220601 has been released since I opened this PR. I can update to it if you'd like.

@dylans
Copy link
Member

dylans commented Jun 8, 2022

@dasa could be for 1.17.3, and an update would be great. Thanks.

@dasa dasa changed the title Upgrade Google Closure Compiler to v20220405 Upgrade Google Closure Compiler to v20220601 Jun 9, 2022
@dasa
Copy link
Contributor Author

dasa commented Jun 9, 2022

an update would be great

PR updated to v20220601

@dylans dylans merged commit 3ed6d59 into dojo:master Jun 11, 2022
@dasa dasa deleted the dasa/update-closure-compiler branch June 12, 2022 20:36
@dasa
Copy link
Contributor Author

dasa commented Jun 13, 2022

could be for 1.17.3

Will you cherry pick to the 1.17 branch?

@dylans
Copy link
Member

dylans commented Jun 20, 2022

could be for 1.17.3

Will you cherry pick to the 1.17 branch?

Yes, will do when I get a chance to release. Let me know if you urgently need a release or if it can wait a few weeks. Thanks!

@dasa
Copy link
Contributor Author

dasa commented Jun 20, 2022

a few weeks is good, thanks

@dasa
Copy link
Contributor Author

dasa commented Jul 19, 2022

Hi @dylans, do you have an updated ETA? Thanks

dylans pushed a commit that referenced this pull request Aug 1, 2022
* Upgrade Google Closure Compiler to v20220405

* Upgrade Google Closure Compiler to v20220601

(cherry picked from commit 3ed6d59)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants