-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
=========================================
- Coverage 67.96% 66.56% -1.4%
=========================================
Files 23 17 -6
Lines 1414 1002 -412
Branches 332 239 -93
=========================================
- Hits 961 667 -294
+ Misses 453 335 -118
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks great! I tested in Chrome, Safari, and Firefox. Here's a couple of smaller issues I've noticed.
- This bar for the scrollbar appears as soon as anything is typed into the text editor. Not causing any issues, just looks a bit odd and doesn't go away.
- The editor doesn't resize vertically when the window is resized
src/styles/runner.m.css
Outdated
position: relative; | ||
height: 100%; | ||
width: 100%; | ||
width: 100% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing semicolon
@nicknisi I have tried to address most of the feedback:
It would be good to try to land this, so I can rebase my live editor and you can rebase your stuff and we can iterate any further in future PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a comment about the event listeners, but once you've reviewed that it looks good to me! 👍
return evt.returnValue; | ||
} | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to clean up these event listeners when the workbench is unloaded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the 0.2.0 there are better lifecycle methods that would make this possible, so let's open an issue to clean that up when we move to 0.2.0 (which will be my next PR).
Enhancement
This PR more fully fleshes out the designed Workbench as well as makes various UI/UX improvements and maintainability improvements.