This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Fix Edge failures #680
Merged
Fix Edge failures #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gadd
reviewed
Sep 14, 2017
| @@ -193,6 +193,8 @@ export class WidgetBase<P = WidgetProperties, C extends DNode = DNode> extends E | |||
|
|
|||
| private _numRootNodes = 0; | |||
|
|
|||
| private _rootNodeKeys: object[]; | |||
There was a problem hiding this comment.
is a root node key really an object?
There was a problem hiding this comment.
Got a typing error when i set it to string[]. The typedoc popup said that properties.key is an object.
matt-gadd
approved these changes
Sep 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
Description:
Fixes edge failures. Makes certain tests sync
Resolves #679