This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Instance WeakMap for widgets in vdom #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agubler
force-pushed
the
widget-base-weak-map
branch
from
c1f864c
to
e9c401c
Compare
matt-gadd
approved these changes
Nov 13, 2017
tomdye
approved these changes
Nov 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
An instance
WeakMapto vdom to share private/protected properties between widget instances and the vdom mechanism. Removes the need to publicly expose methods and properties from the instance just because they are required to process instances during the render process.The next stage would be to remove all the existing double underscrore'd methods (for example
__setProperties__) and reference them from the instance map. This will clean the WidgetBase API to simplypropertiesandchildren