This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Typescript 2.6.1 #774
Merged
Typescript 2.6.1 #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agubler
suggested changes
Nov 15, 2017
src/WidgetBase.ts
Outdated
| export interface WidgetAndElementEvent extends EventTypedObject<'properties:changed'> { | ||
| key: string; | ||
| element: HTMLElement; | ||
| export interface WidgetAndElementEvent<T extends EventType> extends EventObject<T> { |
There was a problem hiding this comment.
Don't think this get used anymore?
src/WidgetBase.ts
Outdated
| @@ -78,7 +78,7 @@ export class WidgetBase<P = WidgetProperties, C extends DNode = DNode> implement | |||
| /** | |||
| * Array of property keys considered changed from the previous set properties | |||
| */ | |||
| private _changedPropertyKeys: string[] = []; | |||
| private _changedPropertyKeys: (string | number)[] = []; | |||
There was a problem hiding this comment.
This should just be string, it is the actual key of the property on the properties object
src/WidgetBase.ts
Outdated
| // Do nothing by default. | ||
| } | ||
|
|
||
| public get properties(): Readonly<P> & Readonly<WidgetProperties> { | ||
| return this._properties; | ||
| } | ||
|
|
||
| public get changedPropertyKeys(): string[] { | ||
| public get changedPropertyKeys(): (string | number)[] { |
There was a problem hiding this comment.
As above, this should just be string[]
There was a problem hiding this comment.
And all the other references to changedPropertyKeys
bryanforbes
force-pushed
the
typescript-2.6.1
branch
from
ad92183
to
1548cbb
Compare
|
Looks reasonable, just a conflict on |
bryanforbes
force-pushed
the
typescript-2.6.1
branch
from
7cdcc29
to
f15ebdb
Compare
bryanforbes
force-pushed
the
typescript-2.6.1
branch
from
0db68fb
to
22f1efa
Compare
bryanforbes
force-pushed
the
typescript-2.6.1
branch
from
22f1efa
to
b807584
Compare
agubler
approved these changes
Nov 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: enhancement
The following has been addressed in the PR:
Description:
Relates to dojo/meta#210