Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid theme and fixed styles #597

Merged
merged 1 commit into from Sep 22, 2018
Merged

Conversation

smhigley
Copy link
Contributor

Type: eature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Resolves #584

@codecov
Copy link

codecov bot commented Sep 21, 2018

Codecov Report

Merging #597 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
+ Coverage   98.91%   98.91%   +<.01%     
==========================================
  Files          42       42              
  Lines        3030     3035       +5     
  Branches      813      813              
==========================================
+ Hits         2997     3002       +5     
  Misses         33       33
Impacted Files Coverage Δ
src/grid/widgets/Grid.ts 84.28% <100%> (+0.22%) ⬆️
src/grid/widgets/Body.ts 95.49% <100%> (+0.04%) ⬆️
src/grid/widgets/Footer.ts 100% <100%> (ø) ⬆️
src/grid/widgets/PlaceholderRow.ts 100% <100%> (ø) ⬆️
src/grid/widgets/Row.ts 89.47% <100%> (+0.58%) ⬆️
src/grid/widgets/Cell.ts 100% <100%> (ø) ⬆️
src/grid/widgets/Header.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7b87c2...dd84d58. Read the comment docs.

@smhigley smhigley merged commit 1dd3cc8 into dojo:master Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants