Use TextInput and Button in Grid #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
agubler
reviewed
Oct 1, 2018
| @@ -35,7 +36,7 @@ export interface ButtonProperties extends ThemedProperties, InputEventProperties | |||
| onClick?(): void; | |||
| } | |||
|
|
|||
| export const ThemedBase = ThemedMixin(WidgetBase); | |||
| export const ThemedBase = ThemedMixin(FocusMixin(WidgetBase)); | |||
There was a problem hiding this comment.
Hah, I never even noticed it was called that 😂
|
You got a failing test. |
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
==========================================
+ Coverage 98.94% 98.94% +<.01%
==========================================
Files 42 42
Lines 3040 3043 +3
Branches 820 820
==========================================
+ Hits 3008 3011 +3
Misses 32 32
Continue to review full report at Codecov.
|
agubler
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description: