Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include focus mixin in focusable widgets #608

Merged
merged 2 commits into from Oct 11, 2018

Conversation

smhigley
Copy link
Contributor

@smhigley smhigley commented Oct 9, 2018

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Related to #342, makes it possible to focus existing widgets using the Focus mixin

@codecov
Copy link

codecov bot commented Oct 9, 2018

Codecov Report

Merging #608 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
+ Coverage   98.96%   98.99%   +0.03%     
==========================================
  Files          42       42              
  Lines        3081     3080       -1     
  Branches      832      830       -2     
==========================================
  Hits         3049     3049              
+ Misses         32       31       -1
Impacted Files Coverage Δ
src/radio/index.ts 100% <100%> (ø) ⬆️
src/tab-controller/index.ts 100% <100%> (ø) ⬆️
src/slider/index.ts 100% <100%> (ø) ⬆️
src/title-pane/index.ts 100% <100%> (ø) ⬆️
src/select/index.ts 100% <100%> (ø) ⬆️
src/time-picker/index.ts 100% <100%> (ø) ⬆️
src/text-area/index.ts 100% <100%> (ø) ⬆️
src/checkbox/index.ts 100% <100%> (ø) ⬆️
src/listbox/index.ts 100% <100%> (+0.81%) ⬆️
src/tab-controller/TabButton.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c07301a...1e70734. Read the comment docs.

@smhigley smhigley merged commit 3ea2c7b into dojo:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants