[enhance] Parameterize Node Affinity #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardogmisiuk
requested review from
andersonluisribeiro,
jonaphael and
marianoleonardo
mprevide
reviewed
Aug 13, 2020
mprevide
reviewed
Aug 13, 2020
mprevide
reviewed
Aug 13, 2020
mprevide
reviewed
Aug 13, 2020
roles/x509-identity-mgmt/templates/x509_identity_mgmt_deployment.yaml.j2
Outdated
Show resolved
Hide resolved
|
this seems like a great improvement, I just left some comments |
mprevide
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
It looks ok to me, but I hope someone like @andersonluisribeiro will review this code too.
42 tasks
This was referenced Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adds a variable to control node affinity. It is useful in tests where we must enforce the services to be in certain nodes to increase performance/prevent other services from disturbing the performance of other ones.
What is the current behavior? (You can also link to an open issue here)
There is no node affinity mapping.
What is the new behavior (if this is a feature change)?
The node affinity can be enabled or disabled via a parameter. The label in which each service will go can be modified too.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Is there any issue related to this PR in other repository? (such as dojot/dojot)
Other information: