Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow choosing VerneMQ, Mosca or LWM2M on dojot deploy #55

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Allow choosing VerneMQ, Mosca or LWM2M on dojot deploy #55

merged 2 commits into from
Aug 25, 2020

Conversation

marianoleonardo
Copy link
Collaborator

@marianoleonardo marianoleonardo commented Aug 20, 2020

  • Please check if the PR fulfills these requirements

    • Tests for the changes have been added (for bug fixes / features)
    • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    This PR introduces the option for the user to choose which iotagent (VerneMQ, Mosca, LWM2M) he wants during the dojot deploy by using tags.

  • What is the current behavior? (You can also link to an open issue here)
    You do not have the option to choose iotagent on deploy.

  • What is the new behavior (if this is a feature change)?
    You have the option to choose iotagent on deploy.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

  • Is there any issue related to this PR in other repository? (such as dojot/dojot)
    Yes, this PR is connected to Deployment - Allow choosing VerneMQ or Mosca dojot#1604

  • Other information:
    To choose the iotagent you must pass the parameter --tags "DESIRED-IOTAGENT-01, DESIRED-IOTAGENT-02" (You must choose between: vernemq, mosca, lwm2m) during the execution of the ansible-playbook.

Copy link
Contributor

@andersonluisribeiro andersonluisribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

eduardogmisiuk
eduardogmisiuk previously approved these changes Aug 21, 2020
Copy link
Contributor

@eduardogmisiuk eduardogmisiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@andersonluisribeiro andersonluisribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants