Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k2v] Add probes #80

Merged
merged 2 commits into from
Nov 24, 2020
Merged

[k2v] Add probes #80

merged 2 commits into from
Nov 24, 2020

Conversation

eduardogmisiuk
Copy link
Contributor

  • Please check if the PR fulfills these requirements

    • Tests for the changes have been added (for bug fixes / features)
    • Docs have been added / updated (for bug fixes / features)

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?
    Verifies the health check that K2V provides.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

  • Is there any issue related to this PR in other repository? (such as dojot/dojot)
    [k2v] Add Health Check and Graceful Shutdown dojot#1849

  • Other information:

@eduardogmisiuk eduardogmisiuk added the Type:Enhancement New feature or request label Nov 23, 2020
@eduardogmisiuk eduardogmisiuk self-assigned this Nov 23, 2020
andersonluisribeiro
andersonluisribeiro approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@andersonluisribeiro andersonluisribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mprevide
Copy link
Contributor

don't worry about deepscan, it is not mandatory.

@eduardogmisiuk eduardogmisiuk merged commit 9fbbea1 into dojot:development Nov 24, 2020
@eduardogmisiuk eduardogmisiuk deleted the k2v_health_check branch November 24, 2020 18:50
@andersonluisribeiro andersonluisribeiro mentioned this pull request Feb 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersonluisribeiro andersonluisribeiro andersonluisribeiro approved these changes

@mprevide mprevide mprevide approved these changes

@marianoleonardo marianoleonardo Awaiting requested review from marianoleonardo

Assignees

@eduardogmisiuk eduardogmisiuk

Labels
Type:Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eduardogmisiuk @mprevide @andersonluisribeiro