Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Import/Export: Import fails [dev] #158

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

mprevide
Copy link
Contributor

@mprevide mprevide commented Aug 27, 2020

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Is there any issue related to this PR in other repository? (such as dojot/dojot)
    Import/Export: Import fails if data already exists dojot#1480

  • Other information:
    I just add @classmethod

@mprevide mprevide requested a review from a team August 27, 2020 19:39
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #158 into development will not change coverage.
The diff coverage is 91.30%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #158   +/-   ##
============================================
  Coverage        73.54%   73.54%           
============================================
  Files               17       17           
  Lines             1705     1705           
============================================
  Hits              1254     1254           
  Misses             451      451           
Impacted Files Coverage Δ
DeviceManager/ImportHandler.py 83.55% <91.30%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a9108...db22f50. Read the comment docs.

Copy link

@thiagodpf thiagodpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was easy!
👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants