Changed license from GPL-3.0 to Apache-2.0 #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 10, 2020 17:12
From now on the flowbroker's services and library are licensed as Apache-2.0. Notes: - Changed to use in the orchestrator the local version of @dojot/flow-node - Fixed the version of the library kubernetes-client used by the orchestrator to be compatible with Node 8.x
From now on the flowbroker's services and library are licensed as Apache-2.0. Notes: - Changed to use in the orchestrator the local version of @dojot/flow-node - Fixed the version of the library kubernetes-client used by the orchestrator to be compatible with Node 8.x
thiagodpf
reviewed
Dec 11, 2020
56 tasks
thiagodpf
approved these changes
Dec 11, 2020
mprevide
reviewed
Dec 11, 2020
| "@dojot/dojot-module-logger": "0.0.1-alpha.5", | ||
| "@dojot/dojot-module": "^0.1.1", | ||
| "@dojot/dojot-module-logger": "^0.1.0", | ||
| "@dojot/flow-node": "../lib", |
mprevide
approved these changes
Dec 11, 2020
mprevide
reviewed
Dec 11, 2020
| @@ -22,7 +45,7 @@ | |||
| "geolib": "^2.0.24", | |||
| "ioredis": "^4.0.0", | |||
| "joi": "^10.2.0", | |||
| "kubernetes-client": "^9.0.0", | |||
| "kubernetes-client": "8.3.6", | |||
There was a problem hiding this comment.
Was there no change between 8 and 9 that could break anything?
There was a problem hiding this comment.
If I'm not wrong we were using version 5.x.x, which is very old. Someone updated the package.json, but not the package-lock.json. Versions greater than 8.3.6 requires newer versions of Node. I think it would be necessary to retest in Kubernetes. Other option is to use the same version that was being used in the lock file. What do you think?
mprevide
pushed a commit
that referenced
this pull request
Jan 11, 2021
Changed license from GPL-3.0 to Apache-2.0
mprevide
pushed a commit
that referenced
this pull request
Jan 12, 2021
Changed license from GPL-3.0 to Apache-2.0
mprevide
referenced
this pull request
in mprevide/flowbroker
Jan 12, 2021
Changed license from GPL-3.0 to Apache-2.0
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From now on the flowbroker's services and library are licensed as Apache-2.0.
Notes:
orchestrator to be compatible with Node 8.x
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Changes the license to Apache-2.0
What is the current behavior? (You can also link to an open issue here)
NA
What is the new behavior (if this is a feature change)?
NA
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
NA
Is there any issue related to this PR in other repository? (such as dojot/dojot)
dojot - Studies for changing Software License to Apache 2.0 dojot#1879
Other information: