Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide unused items #18

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Conversation

luisfelipefurlan
Copy link
Member

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)
    Shows all menu items

  • What is the new behavior (if this is a feature change)?
    Shows only implemented items

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Is there any issue related to this PR in other repository? (such as dojot/dojot)
    [gui-v2] remove/comment unused sidebar menus dojot#1767

  • Other information:

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #18 into development will decrease coverage by 0.90%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #18      +/-   ##
===============================================
- Coverage        73.18%   72.27%   -0.91%     
===============================================
  Files               30       30              
  Lines              220      220              
  Branches            21       23       +2     
===============================================
- Hits               161      159       -2     
  Misses              50       50              
- Partials             9       11       +2     
Flag Coverage Δ
#guiV2 72.27% <0.00%> (-0.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/js/common/components/Drawer/Drawer.jsx 80.00% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c154f3f...b5f1299. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants