[DOJOT-84] - New Menu #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are two DeepScan issues to be fixed:
|
LuanEdCosta
previously approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Very good job.
I just want to point one thing that we can improve in the future:
- The app navbar is rendered by every micro app, but the drawer is rendered by the container micro app. This makes the navbar flashes when you switch from one micro app to another.
Possible Solution: move the navbar component to the container micro app and use React portals to change its title on every page.
LuanEdCosta
approved these changes
Aug 19, 2022
This was referenced Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dojot.atlassian.net/browse/DOJOT-84