Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Login - Should be checked the error validation on handleSubmit #31

Merged
merged 8 commits into from
Jan 15, 2021

Conversation

wellitonSouza
Copy link

@wellitonSouza wellitonSouza commented Dec 22, 2020

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@wellitonSouza wellitonSouza requested a review from a team as a code owner December 22, 2020 19:55
@wellitonSouza wellitonSouza changed the title Issue 1860 Dashboard Login - Should be checked the error validation on handleSubmit Dec 22, 2020
@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #31 (a44fd9e) into development (137da7d) will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #31      +/-   ##
===============================================
+ Coverage        74.02%   74.34%   +0.32%     
===============================================
  Files               30       30              
  Lines              231      230       -1     
  Branches            26       26              
===============================================
  Hits               171      171              
  Misses              48       48              
+ Partials            12       11       -1     
Flag Coverage Δ
guiV2 74.34% <ø> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/js/views/login/View.jsx 76.00% <ø> (+2.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 137da7d...a44fd9e. Read the comment docs.

@mprevide
Copy link

mprevide commented Dec 22, 2020

Always check with the team if any PR should not go to the release/v0.x.x
I don't know about this one, but...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants