-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Line Chart y-axis scale #5
Conversation
@@ -9,7 +9,7 @@ | |||
"build:stage": "cross-env NODE_ENV=stage node bin/commands.js build", | |||
"build:stage:s3": "cross-env S3_DEPLOY=true NODE_ENV=stage node bin/commands.js build", | |||
"clean": "rimraf docroot", | |||
"test": "jest --no-cache", | |||
"test": "TZ=UTC jest --no-cache", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool xD
<YAxis /> | ||
<CartesianGrid strokeDasharray="3 3" /> | ||
<XAxis tickFormatter={formatDate} dataKey='timestamp' /> | ||
<YAxis domain={['auto', 'auto']} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
<YAxis /> | ||
<CartesianGrid strokeDasharray='3 3' /> | ||
<XAxis tickFormatter={formatDate} dataKey='timestamp' /> | ||
<YAxis domain={['auto', 'auto']} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
domain={['auto', 'auto']} | ||
/> | ||
<YAxis /> | ||
<CartesianGrid strokeDasharray="4 4" /> | ||
<YAxis domain={['auto', 'auto']} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Adding configs to a specific file
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug Fix
What is the current behavior? (You can also link to an open issue here)
y axis always starts at 0
What is the new behavior (if this is a feature change)?
automatically generated Y-axis domain range
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Is there any issue related to this PR in other repository? (such as dojot/dojot)
[Dashboard] Line Chart: y-axis scale dojot#1684
Other information: