Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Line Chart y-axis scale #5

Merged
merged 5 commits into from
Sep 21, 2020
Merged

fix: Line Chart y-axis scale #5

merged 5 commits into from
Sep 21, 2020

Conversation

luisfelipefurlan
Copy link
Member

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug Fix

  • What is the current behavior? (You can also link to an open issue here)
    y axis always starts at 0

  • What is the new behavior (if this is a feature change)?
    automatically generated Y-axis domain range

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Is there any issue related to this PR in other repository? (such as dojot/dojot)
    [Dashboard] Line Chart: y-axis scale dojot#1684

  • Other information:

@mprevide mprevide changed the title Dev luis fix: Line Chart: y-axis scale Sep 18, 2020
@@ -9,7 +9,7 @@
"build:stage": "cross-env NODE_ENV=stage node bin/commands.js build",
"build:stage:s3": "cross-env S3_DEPLOY=true NODE_ENV=stage node bin/commands.js build",
"clean": "rimraf docroot",
"test": "jest --no-cache",
"test": "TZ=UTC jest --no-cache",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool xD

<YAxis />
<CartesianGrid strokeDasharray="3 3" />
<XAxis tickFormatter={formatDate} dataKey='timestamp' />
<YAxis domain={['auto', 'auto']} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

<YAxis />
<CartesianGrid strokeDasharray='3 3' />
<XAxis tickFormatter={formatDate} dataKey='timestamp' />
<YAxis domain={['auto', 'auto']} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

domain={['auto', 'auto']}
/>
<YAxis />
<CartesianGrid strokeDasharray="4 4" />
<YAxis domain={['auto', 'auto']} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mprevide mprevide changed the title fix: Line Chart: y-axis scale fix: Line Chart y-axis scale Sep 18, 2020
@luisfelipefurlan luisfelipefurlan merged commit 1f15cf3 into development Sep 21, 2020
luisfelipefurlan referenced this pull request in luisfelipefurlan/gui-v2 Mar 24, 2021
Adding configs to a specific file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants