Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests #61

Merged
merged 15 commits into from
Sep 20, 2019
Merged

Unit tests #61

merged 15 commits into from
Sep 20, 2019

Conversation

juliamourac
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Unit tests

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?
    Added unit tests for History and Persister's services, with 75% coverage

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Is there any issue related to this PR in other repository? (such as dojot/dojot)

  • Other information:

@juliamourac juliamourac requested a review from a team September 13, 2019 14:26
@mprevide
Copy link
Contributor

mprevide commented Sep 16, 2019

Could you add codecov to the repository? :)
it could be in this same PR.

@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (development@feb70d1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development      #61   +/-   ##
==============================================
  Coverage               ?   73.62%           
==============================================
  Files                  ?        7           
  Lines                  ?      417           
  Branches               ?        0           
==============================================
  Hits                   ?      307           
  Misses                 ?      110           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb70d1...1572ac2. Read the comment docs.

@mprevide
Copy link
Contributor

mprevide commented Sep 19, 2019

Could you remove /tests and setup.py from codecov statistics?
@juliamourac

Copy link
Contributor

@mprevide mprevide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants