Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[development] History - Correction of problems with the logger #85

Merged
merged 3 commits into from
Sep 2, 2020
Merged

[development] History - Correction of problems with the logger #85

merged 3 commits into from
Sep 2, 2020

Conversation

thiagodpf
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

bug fix

  • What is the current behavior? (You can also link to an open issue here)
  • There were not many logs in the component;
  • When the LOG_LEVEL environment variable was set to a minuscule value, there was a problem with the component initialization;
  • When the environment variable LOG_LEVEL was initialized with the value INFO and later, if the admin wanted to change this value to DEBUG, the debug messages were not logged.
  • What is the new behavior (if this is a feature change)?
  • more logs have been added to the functions;
  • env_var LOG_LEVEL value converted to uppercase;
  • The error that occurred when trying to change the log level has been fixed (the level of the StreamHandler of the log was not being changed).
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Is there any issue related to this PR in other repository? (such as dojot/dojot)

dojot/dojot#1513
dojot/dojot#1515

  • Other information:

I changed the server port in standalone mode to 8787 because port 8000 is commonly used by Kong in the dojot docker-compose, so to be able to run the component (in standalone mode for debug) together with the dojot, this change was necessary.

The error that occurred when trying to change the log level
has been fixed (the level of the StreamHandler of the log was
not being changed).

In addition, more logs have been added to the functions.
@thiagodpf thiagodpf requested a review from a team September 2, 2020 03:03
@thiagodpf thiagodpf self-assigned this Sep 2, 2020
@thiagodpf thiagodpf changed the title [development] Correction of problems with the logger [development] History - Correction of problems with the logger Sep 2, 2020
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #85 into development will decrease coverage by 0.41%.
The diff coverage is 70.68%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #85      +/-   ##
===============================================
- Coverage        73.44%   73.02%   -0.42%     
===============================================
  Files                7        7              
  Lines              418      456      +38     
===============================================
+ Hits               307      333      +26     
- Misses             111      123      +12     
Impacted Files Coverage Δ
history/api/models.py 75.23% <69.64%> (-1.48%) ⬇️
history/app.py 76.92% <100.00%> (ø)
history/conf.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89fa7c1...f8b13aa. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants