-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring the libdokanfuse headers' directory-structure in line with libfuse #250
Labels
Comments
@Rondom Hi, That's a good idea! Do you think you can make a pull request that fix it? |
That's why I asked :-) |
❤️ Do not forget the installer also 😃 ! |
@Rondom , did had the time to see about this issue ? |
Rondom
added a commit
to Rondom/dokany
that referenced
this issue
Sep 14, 2016
This adds an install target that installs the headers in the same directory structure as libfuse. This makes it easy to support compiling against either libfuse or libdokanfuse1 from the same codebase. This fixes dokan-dev#250 for manual compilations under Cygwin or for MingW.
Rondom
added a commit
to Rondom/dokany
that referenced
this issue
Sep 14, 2016
Installs the public FUSE headers in a directory structure that resembles that of Linux FUSE. Linux FUSE requires a fuse.h in the top-level include-directory. Closes dokan-dev#250.
Rondom
added a commit
to Rondom/dokany
that referenced
this issue
Sep 15, 2016
Installs the public FUSE headers in a directory structure that resembles that of Linux FUSE. Linux FUSE requires a fuse.h in the top-level include-directory. Closes dokan-dev#250.
Rondom
added a commit
to Rondom/dokany
that referenced
this issue
Sep 20, 2016
Installs the public FUSE headers in a directory structure that resembles that of Linux FUSE. Linux FUSE requires a fuse.h in the top-level include-directory. Closes dokan-dev#250.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current directory structure of Dokan_FUSE is not in line with the original libfuse. Compiling the same codebase with both libfuse and libdokanfuse currently requires "hacks" such as symlinking or manually copying files around (if "advanced" headers such as fuse_opt.h are used). What do others think about bringing libdokanfuse in line with libfuse in that regard to simplify things?
The organization of the source does not need to reflect the installation-path of the headers (it does not for libfuse either) If people prefer to leave the files as they are in the source tree it can also be solved within CMakeLists.txt
libfuse puts its headers in a subdirectory inside include. The fuse.h at the toplevel is only a dummy (see link).
Dokan_FUSE currently looks like this:
The text was updated successfully, but these errors were encountered: