Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring the libdokanfuse headers' directory-structure in line with libfuse #250

Closed
Rondom opened this issue May 27, 2016 · 4 comments
Closed

Comments

@Rondom
Copy link
Contributor

Rondom commented May 27, 2016

The current directory structure of Dokan_FUSE is not in line with the original libfuse. Compiling the same codebase with both libfuse and libdokanfuse currently requires "hacks" such as symlinking or manually copying files around (if "advanced" headers such as fuse_opt.h are used). What do others think about bringing libdokanfuse in line with libfuse in that regard to simplify things?

The organization of the source does not need to reflect the installation-path of the headers (it does not for libfuse either) If people prefer to leave the files as they are in the source tree it can also be solved within CMakeLists.txt

libfuse puts its headers in a subdirectory inside include. The fuse.h at the toplevel is only a dummy (see link).

fuse296/include
├── fuse
│   ├── cuse_lowlevel.h
│   ├── fuse_common_compat.h
│   ├── fuse_common.h
│   ├── fuse_compat.h
│   ├── fuse.h
│   ├── fuse_lowlevel_compat.h
│   ├── fuse_lowlevel.h
│   └── fuse_opt.h
├── fuse.h
└── ulockmgr.h

Dokan_FUSE currently looks like this:

dokan_fuse/include
├── dokanfuse.h
├── fuse_common.h
├── fuse.h
├── fusemain.h
├── fuse_opt.h
├── fuse_sem_fix.h
├── fuse_win.h
├── ScopeGuard.h
└── utils.h
@Rondom Rondom changed the title Bring the fuse headers' directory-structure in line with libfuse Bring the libdokanfuse headers' directory-structure in line with libfuse May 27, 2016
@Liryna
Copy link
Member

Liryna commented May 27, 2016

@Rondom Hi,

That's a good idea! Do you think you can make a pull request that fix it?

@Rondom
Copy link
Contributor Author

Rondom commented May 27, 2016

That's why I asked :-)

@Liryna
Copy link
Member

Liryna commented May 27, 2016

❤️

Do not forget the installer also 😃 !

@Maxhy Maxhy added this to the 1.0.0 milestone Jun 3, 2016
@Liryna
Copy link
Member

Liryna commented Jun 25, 2016

@Rondom , did had the time to see about this issue ?
(If I do not make mistakes I think I seen a fix for it in your repository at a moment)

Rondom added a commit to Rondom/dokany that referenced this issue Sep 14, 2016
This adds an install target that installs the headers in the same
directory structure as libfuse. This makes it easy to support compiling
against either libfuse or libdokanfuse1 from the same codebase.
This fixes dokan-dev#250 for manual compilations under Cygwin or for MingW.
Rondom added a commit to Rondom/dokany that referenced this issue Sep 14, 2016
Installs the public FUSE headers in a directory structure that resembles
that of Linux FUSE. Linux FUSE requires a fuse.h in the top-level
include-directory.
Closes dokan-dev#250.
Rondom added a commit to Rondom/dokany that referenced this issue Sep 15, 2016
Installs the public FUSE headers in a directory structure that resembles
that of Linux FUSE. Linux FUSE requires a fuse.h in the top-level
include-directory.
Closes dokan-dev#250.
Rondom added a commit to Rondom/dokany that referenced this issue Sep 20, 2016
Installs the public FUSE headers in a directory structure that resembles
that of Linux FUSE. Linux FUSE requires a fuse.h in the top-level
include-directory.
Closes dokan-dev#250.
@Liryna Liryna closed this as completed in 8c5578f Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants