Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irp pending timeout issue #55

Merged
merged 7 commits into from
Sep 7, 2015

Conversation

marinkobabic
Copy link
Contributor

  • The timeout per device has been implemented. The DokanOptions has a new property Timeout (Milliseconds).
  • Prevent thread termination if not enough resources
  • Fix BSOD in security

@Liryna
Please create a .Net Method ResetTimeout. The exported method exists since a longer time https://github.com/dokan-dev/dokany/blob/master/dokan/dokan.def#L13. This method can be executed inside of the callbacks, to extend the timeout of the current request.

Please add the new DokanOption.Timeout

…an get the invalid status, is for example a IRP timeout. We only accept, that the device is no longer there as a reason to terminate the thread. In all other cases there must be a driver issue, which must be fixed.
fix bsod in security
prevent thread from terminated if not enough resources
@Maxhy
Copy link
Member

Maxhy commented Sep 7, 2015

At first look/test this is good!
You really did an amazing quick job, thanks for this PR. I'm gonna merge it but additional tests would be preferable to be sure it breaks nothing. Lets consider master as unstable for now ;).

Maxhy pushed a commit that referenced this pull request Sep 7, 2015
@Maxhy Maxhy merged commit cdcb26d into dokan-dev:master Sep 7, 2015
@Liryna Liryna mentioned this pull request Sep 7, 2015
12 tasks
@Liryna
Copy link
Member

Liryna commented Sep 7, 2015

Very very nice PR @marinkobabic TY ❤️ !
I updated the TODO and will update the .NET wrapper as you requested for the next release :) !

@marinkobabic marinkobabic deleted the IrpPendingTimeoutIssue branch January 14, 2016 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants