Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass docker-args-build to apt "docker run" #38

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

scjody
Copy link
Contributor

@scjody scjody commented Nov 18, 2019

This passes docker-args-build to the docker run commands used to run apt commands. This solves an issue seen at Plotly.

Note that we don't currently call the new docker-args-process-build because IMAGE_TAG isn't available to us. It also appears to be unavailable in dokku's builder-build so I'm unsure how the new trigger is supposed to work. Since Plotly uses only the older docker-args-build, this is fine for us.

This is currently untested but I'll update this PR when I've had the chance to test it on an internal Plotly system.

@josegonzalez FYI

@josegonzalez
Copy link
Member

josegonzalez commented Nov 18, 2019

Yeah this seems reasonable.

Also the docker-args-process-build missing the IMAGE_TAG argument is a definite bug in Dokku, though I can revisit that in a future release.

Bump me once this passes and I'll merge to master/release.

@scjody
Copy link
Contributor Author

scjody commented Nov 19, 2019

This has passed my testing. (Docker arguments generated by an internal Plotly plugin are successfully passed to the container that runs apt.)

@josegonzalez josegonzalez merged commit 7fca1da into dokku-community:master Nov 19, 2019
@josegonzalez
Copy link
Member

josegonzalez commented Nov 19, 2019

Released as a patch in 0.9.7 as this is definitely a bug in my mind.

@scjody scjody deleted the add-build-arguments branch November 19, 2019 13:29
@scjody
Copy link
Contributor Author

scjody commented Nov 19, 2019

Thanks for the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants