Pass docker-args-build to apt "docker run" #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes
docker-args-build
to thedocker run
commands used to run apt commands. This solves an issue seen at Plotly.Note that we don't currently call the new
docker-args-process-build
becauseIMAGE_TAG
isn't available to us. It also appears to be unavailable in dokku'sbuilder-build
so I'm unsure how the new trigger is supposed to work. Since Plotly uses only the olderdocker-args-build
, this is fine for us.This is currently untested but I'll update this PR when I've had the chance to test it on an internal Plotly system.
@josegonzalez FYI