Upgrade dokku version

[d1ceward]

Upgrade to dokku v0.12.4 with new go plugins, etc...
Installation work fine (tested multiple time on different arch linux server)

This need an update of herokuish AUR package to v0.4.0
Link to the PR -> dokku/arch-herokuish/pull/1

[MorrisJobke]

cc @josegonzalez

[josegonzalez]

Does this work on all arch systems? I feel as though this needs golang as a dependency, because of the make go-build invocation.

[d1ceward]

Not needed, because it build go plugins in docker containers.

From dokku repository

# /Makefile
...
go-build:
  basedir=$(PWD); \
    for dir in plugins/*; do \
	if [ -e $$dir/Makefile ]; then \
          # PLUGIN_MAKE_TARGET ?= build-in-docker
	  $(MAKE) -e -C $$dir $(PLUGIN_MAKE_TARGET) || exit $$? ;\
	fi ;\
    done
...

# Network plugin as example
# /plugins/network/Makefile
...
build-in-docker: clean
  docker run --rm \
    -v $$PWD/../..:$(GO_REPO_ROOT) \
    -w $(GO_REPO_ROOT)/plugins/network \
    $(BUILD_IMAGE) \
    bash -c "GO_ARGS='$(GO_ARGS)' make build" || exit $$?

[josegonzalez]

Is docker guaranteed to be installed before this gets invoked?

[d1ceward]

Docker is in dependencies

But I just noticed 2 issues :

• It needs to have current user in docker group to create container otherwise install fail
• Docker daemon service needs to be enabled by user with a fresh install otherwise install fail too

I don't know how to manage this, because any change on user group need re-login and starting service need elevation...

Should I switch building in container to system ?

[josegonzalez]

What might make more sense is to modify the Dokku release process to expose a tarball with all the files already compiled, and then arch releases just download those binaries.

You can of course do the compilation on the system itself, but that will slow down installation.

[d1ceward]

I moved compilation on system (added go dependency) and upgraded to v0.12.5.

FYI: Full installation take ~4-5 min on my shitty 2 core laptop (with all dependencies).

[josegonzalez]

If I exposed all the compiled contents as a binary somewhere, could you modify this to instead pull that and extract it into place? I don't like the idea of depending on userland to compile files that may result in wildly different things if a user has slightly different installed golang.

[d1ceward]

This is a good idea and yes, i'll keep helping to maintain this package as i'm actively using dokku on Arch (i have several projects using this, was on Heroku before)

[josegonzalez]

@d1ceward what needs to happen here to get this resolved?

[d1ceward]

Actually everything work (i'm using it, that's why i'm keeping it updated) but as said above it may need exposed plugins binaries to remove golang dependency.